fix: replace console.log with MDS.log in service.js, use PNG for shop icon - #22
Merged
Merged
Conversation
… icon Minima's ServiceJSRunner (Rhino) has no console object — every console.log call threw ReferenceError every 10 seconds. Replaced all occurrences with MDS.log(). Also switched shop dapp.conf icon from icon.svg to icon.png since PNG is universally supported by all Minima hub versions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServiceJSRunnerruns in Rhino —consoleis not defined in that context. Allconsole.log()calls inservice.jsthrewReferenceError: console is not definedevery 10 seconds. Replaced all occurrences withMDS.log().dapp.confwas referencing./icon.svg— switched to./icon.pngwhich is universally supported across all Minima hub versions.Test plan
miniMerchInbox.mds.zipon vendor nodeSERVICEJS_POLLerrors are gone from logs🤖 Generated with Claude Code