Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tobiajo
force-pushed
the
tj/totry-timeout-spec
branch
6 times, most recently
from
August 31, 2026 10:51
4bcf7fb to
6c4c70b
Compare
mr-git
reviewed
Aug 31, 2026
tobiajo
force-pushed
the
tj/totry-timeout-spec
branch
from
August 31, 2026 12:03
6c4c70b to
69a943e
Compare
This was referenced Sep 6, 2026
Author
|
Redundant if #425 lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests for the
ioToTrytimeout, on top of #330.On master,
ioToTryusessyncStep+unsafeRunTimed. On timeoutunsafeRunTimedfire-and-forgets a cancel and returns immediately — it never waits for finalizers, and.uncancelablework keeps running. kafka-flow'sTopicFlow.safeguardtakes a semaphore permit inside.uncancelable; the poll thread moves on while the abandoned fiber still holds the permit, and every subsequentpollblocks on the semaphore — the consumer silently stops processing.All three specs fail on master, pass on this branch:
To see both directions:
```
git checkout master -- core/src/main/scala/com/evolutiongaming/catshelper/ToTry.scala
sbt "core/testOnly *ToTryTimeoutSpec"
```