Conversation
stasimus
force-pushed
the
fix/923-migrate-schema-swallows-errors
branch
from
July 19, 2026 17:30
8d0b3a8 to
d684b7b
Compare
Coverage Report for CI Build 29823147645Coverage increased (+1.7%) to 93.194%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
mr-git
reviewed
Jul 21, 2026
mr-git
left a comment
mr-git
left a comment
Collaborator
There was a problem hiding this comment.
Overall I like this, though I'd like to make sure that we have all storages in sync and in good shape before we update to version, which contains this change (yes, I am a bit afraid).
mr-git
force-pushed
the
fix/923-migrate-schema-swallows-errors
branch
2 times, most recently
from
July 21, 2026 10:48
1413a9d to
846cb19
Compare
mr-git
marked this pull request as draft
July 21, 2026 15:03
Collaborator
|
blocked by #944! |
stasimus
force-pushed
the
fix/923-migrate-schema-swallows-errors
branch
3 times, most recently
from
July 31, 2026 21:00
6ebee23 to
f3f569b
Compare
Contributor
Author
|
Re-triggering required check after org policy rollout fix |
stasimus
force-pushed
the
fix/923-migrate-schema-swallows-errors
branch
from
August 1, 2026 19:18
f3f569b to
6ec8fc0
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #923.
MigrateSchemaused.voidError, swallowing migration errors and advancing the schema version anyway, so a transient failure permanently skipped a step. Now errors propagate andsetVersionruns only on success, keeping the version truthful. Adds tests. Note: legacy schemas without a version now fail loudly on re-added columns.