Skip to content

Deprecate never-applied load balancing flag - #391

Open
stasimus wants to merge 1 commit into
series/5.xfrom
deprecate-remote-dcs-flag
Open

stasimus wants to merge 1 commit into
series/5.xfrom
deprecate-remote-dcs-flag

Conversation

@stasimus

@stasimus stasimus commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

allowRemoteDcsForLocalConsistencyLevel has been parsed since the first commit in 2018 but was never passed to the driver; usedHostsPerRemoteDc, which it depends on, was removed long ago. Deprecated with removal in 6.0.0. The config key still parses so existing files keep loading. Binary compatible, versionPolicyCheck passes. Closes the thread on #385.

Summary by CodeRabbit

  • Deprecation

    • Marked allowRemoteDcsForLocalConsistencyLevel for removal in version 6.0.0.
    • Clarified that this setting is retained for compatibility and does not affect driver behavior.
  • Maintenance

    • Suppressed related deprecation warnings in configuration handling and tests.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e86ae093-4b26-4649-8028-6df2b693e66a

📥 Commits

Reviewing files that changed from the base of the PR and between 7644970 and 8404713.

📒 Files selected for processing (3)
  • scassandra/src/main/scala/com/evolutiongaming/scassandra/LoadBalancingConfig.scala
  • scassandra/src/main/scala/com/evolutiongaming/scassandra/LoadBalancingConfigImplicits.scala
  • scassandra/src/test/scala/com/evolutiongaming/scassandra/LoadBalancingConfigSpec.scala

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request marks allowRemoteDcsForLocalConsistencyLevel as deprecated for removal in 6.0.0. It documents the compatibility behavior and suppresses deprecation warnings in the implicit reader and related test.

Changes

Load balancing configuration deprecation

Layer / File(s) Summary
Deprecation compatibility handling
scassandra/src/main/scala/com/evolutiongaming/scassandra/LoadBalancingConfig.scala, scassandra/src/main/scala/com/evolutiongaming/scassandra/LoadBalancingConfigImplicits.scala, scassandra/src/test/scala/com/evolutiongaming/scassandra/LoadBalancingConfigSpec.scala
The compatibility field is marked deprecated for removal in version 6.0.0. Documentation explains that the field does not affect the driver. The reader and test expression suppress deprecation warnings. The field type, default value, and reader logic remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: migesok

Merge Risk: ⚪ Minimal · up to 84047

This compatibility-only change preserves existing configuration behavior and is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: deprecating the load-balancing flag that has never affected the driver.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deprecate-remote-dcs-flag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@stasimus
stasimus changed the base branch from master to series/5.x September 12, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant