Skip to content

SED-4855 Decommission the Keyword packages - #1451

Merged
david-stephan merged 2 commits into
masterfrom
SED-4855-decommission-the-keyword-packages
Sep 18, 2026
Merged

david-stephan merged 2 commits into
masterfrom
SED-4855-decommission-the-keyword-packages

Conversation

@neogucky

Copy link
Copy Markdown
Collaborator

No description provided.

@neogucky
neogucky requested a review from dvladir September 10, 2026 14:41

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated "Keyword Packages" feature, including all its associated services, components, models, and modules (such as FunctionPackagesModule, KeywordPackagesService, and FunctionPackageTypeRegistryService) from the codebase. Feedback was provided regarding an unsafe non-null assertion (!) on keyword.attributes in function.module.ts, suggesting the use of optional chaining with a fallback value to prevent potential runtime errors.

Comment on lines 148 to 149
map((keyword) => keyword.attributes!['name']),
map((name) => `${name}.sta`),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The use of the non-null assertion operator (!) on keyword.attributes is unsafe because the attributes property is optional on the Function type. This could lead to a runtime error if attributes is undefined. It's safer to use optional chaining (?.) and provide a fallback value for the name, such as the keyword's ID which is available in the id constant. Additionally, combining the two map operators will make the code more concise.

                        map((keyword) => `${keyword.attributes?.['name'] || id}.sta`)

@david-stephan
david-stephan merged commit 68051ee into master Sep 18, 2026
@david-stephan
david-stephan deleted the SED-4855-decommission-the-keyword-packages branch September 18, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants