SED-4791 add-performance-analytics-to-node-details - #705
Open
david-stephan wants to merge 2 commits into
Open
david-stephan wants to merge 2 commits into
david-stephan wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ingestion of artefactHash (representing the static position of an artefact within a resolved plan) into measurements and metrics. It updates ExecutionMetricSample, MetricsExecutionPlugin, and the time-series plugins to support and propagate this new attribute, alongside adding comprehensive tests to verify its behavior. The review feedback highlights a potential memory leak and test interference issue in the newly added MetricsExecutionPluginArtefactHashTest due to registering a test handler to a static list without unregistering it, and suggests adding a teardown method to clean it up.
cl-exense
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.