Skip to content

solve breaking change in insert method #9

Description

@fbucek

Method insert now without generic parameter not returning struct.

What is better approach. Have breaking change with insert method and new method insert_get::<T> which will cause breaking change or rename insert without generic parametr and add new method without return. e.g. insert_nr ( no return )
insert::<T> and insert_noret

Looks to me, that this with breaking change looks ok

let new_car = NewCar { name: "Test" };
let car = new_car.insert_get::<Car>("cars").unwrap();
new_car.insert("cars").unwrap();

Then do not forget to update documentation.

  • update README.md

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions