Flatten PlanetVim menu style choices - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
PlanetVim -> Menu Style.*submenu entries with flattened entriesPlanetVim -> Menu Style: Emoji,PlanetVim -> Menu Style: Plain, andPlanetVim -> Menu Style: Descriptiveinautoload/planet/menu/planet.vimand adjust their menu ordering slots.tests/test_menu_styles.vim(verify the old submenu is absent and the new entries exist) andtests/test_menu_state.vim(adjust expectedmenu_info()paths for style assertions).docs/GUIDE.md, the built-in helpdoc/planetvim.txt, anddocs/MENU_REVIEW.mdto describe the directMenu Style:entries and the new wording.Testing
python3 -m unittest tests.test_menu_contractand it passed successfully.python3 -m unittest discover -s tests -p 'test_*.py'and the suite completed successfully (115 tests run, 14 skipped).python3 scripts/test.py tests/test_menu_styles.vim tests/test_menu_state.vim, but those tests could not execute because GVim was not available in the environment.Codex Task