ci(smoke): keep containers on failed runs; dump user state on reply timeout - #570
Merged
Conversation
…ounded user state on reply timeout Two observability gaps from the 2026-08-18 depot smoke hunt: --keep-running only applied on the success path (a failed run removed exactly the container you need to inspect), and a reply-timeout carried only the last 8 messages — no user-runtime room/topic/unread state, leaving 'user side never observed the reply' indistinguishable from 'reply never sent'.
The converging-stub cases need three poll rounds at a 1s poll interval; a 2s wall-clock budget raced the poll cadence and failed under CI load (PR #570 run 32173170068, Brain acceptance matrix). The convergence check runs before the deadline check each round, so the budget only needs to comfortably cover the round count. Failure-path budgets stay at 1s; those stubs never converge and are deterministic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two observability gaps found during the 2026-08-18 depot smoke hunt:
--keep-runningonly applied on the success path — a failed run deleted exactly the container you need to inspect. Now honored on failure too.No behavior change to the passing path. Durable-home suite green locally.