fix(cli): install native Linux Desktop tarballs - #784
Conversation
Signed-off-by: Damian Reeves <957246+DamianReeves@users.noreply.github.com>
✅ Deploy Preview for angry-raman-7c44f6 canceled.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Companion UI release metadata fix: finos/morphir-ui#33. The UI landed commit will be pinned here before merge. @codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: Damian Reeves <957246+DamianReeves@users.noreply.github.com>
|
UI #33 has landed at 92d5471a9ceda5d771a8d17ed5cc1a4c2c1aec20 after all CI and packaging checks passed. The new commit only pins that reviewed, landed UI tree. The earlier parent review completed without findings. Native post-rebase unit/integration tests and strict Clippy pass. Please review the final head. @codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Finish the installed Desktop acceptance work for
morphir-ds9e.3.2.Real Linux packaging exposed a missing-executable failure: electron-builder wraps tar entries in
morphir-desktop-<version>-linux-<arch>/, while local installation declared a root-level executable.Derive the correct path from the validated version and target platform, not the downloaded
filename. This supports renamed archives, ARM64, x64, and preview versions.
Linux lifecycle integration fixtures now use the real tar directory layout and a renamed archive
instead of a raw executable. Companion UI release metadata received the same correction in
finos/morphir-ui#33, now landed and pinned here at
92d5471a9ceda5d771a8d17ed5cc1a4c2c1aec20. The Bun TypeScript demo remains unchanged.Verification
2 existing external-tool integration cases ignored locally.
bun run tools/demo-desktop.ts --prepare-onlybuilt, packaged and installed a real LinuxARM64 Desktop successfully using the corrected CLI.
3147cd41and aligning its Rust submodule pin, native unit tests,all 60 enabled CLI integration tests, and strict all-target Clippy passed again.
Real isolated acceptance
The installed Linux ARM64 Desktop passed two GUI launches using
morphir desktop --offline --wait.Each displayed the selected sample model and
applyLambdain Insight and XRay, then closednormally with exit 0.
Bubblewrap mounted only installed files, the sample model, system libraries/configuration and
the WSLg display socket. The checkout, build snapshot and original package were not mounted.
A new network namespace had no routes. Positive host file/TCP controls succeeded; isolated
controls failed. Running Desktop process audits confirmed the same isolation. Electron's
sandbox was not disabled and no global network/security setting was changed.
Package SHA-256:
504a9305eb867ead794c79757d35d573e9e4c6366afecb828d9e271bf3f4f04e, 71 verified files.op-8b4ccc92-539f-4e48-95d9-c09153909efd,launch-e0077078-b36e-4369-83eb-40e0cb6181bd.op-29cef130-5b6d-4fbb-9c1f-e2a2860c70af,launch-2a257dfb-4856-48b7-b5c7-263046d2b669.Both CLI and Desktop logs contain matching ready and exit records. Strict isolation was tested
on Linux under WSL2; native Windows GUI acceptance is separate evidence.
No follow-up story was created to defer a defect from this task.