chore(deps): bump google-events#297
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the dependency range for google-events from a pinned version ==0.5.0 to >=0.5.0,<1.0.0 in pyproject.toml and updates the lockfile uv.lock accordingly. It also removes the exclude-newer configuration options from uv.lock. No review comments were provided, so there is no additional feedback.
Testing SummaryValidated the google-events upgrade path with comprehensive testing: Note: 0.14.0 latest google-events version at time of comment. Smoke Tests Performed1. API Surface Validation
2. JSON/Protobuf Deserialization
3. End-to-End Integration
4. Version Compatibility
5. Deployment Tests
Results
The upgrade from |
shettyvarun268
left a comment
There was a problem hiding this comment.
Thanks for updating google-events—this looks good to merge and unblock #253!
Regarding the # type: ignore[arg-type] added on line 224 in src/firebase_functions/firestore_fn.py: the mypy error happens because firestore_event_data is currently reused as both the raw protobuf (_firestore.DocumentEventData) and the converted domain object (DocumentSnapshot / Change).
Since this doesn't affect runtime behavior, I'm happy to approve and merge this as-is. However, let's open a follow-up PR to separate firestore_event_data into two distinct variables (proto_event_data vs domain_event_data). That will allow us to cleanly remove both the # type: ignore[arg-type] on line 224 and the three _typing.cast calls on lines 176–186.
|
@shettyvarun268 Thanks for the review! I will start working on that follow up asap :) |
Fixes #253