chore: clean up Obsidian scan compatibility boundaries - #119
Draft
ClaudiaFang wants to merge 3 commits into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
e2e/**andscripts/**from the Obsidian runtime lint pass while retaining strict rules for shipping plugin code.npm run check:obsidian-compat, which inspects builtmain.jsfor staticnode:crypto,node:child_process,node:utilimports and direct nativefetch()calls.requestUrlarchitecture: GitHub, GitLab, and Gitea useBaseGitService.safeRequest().Official scan audit
fetchglobalThisnode:crypto,node:child_process,node:utilwindow-qualifiedsrc/**main.jspasses the production compatibility guard with no prohibited Node imports or direct native fetch calls.Verification
npm run lintnpm run build(including Obsidian 1.11.0 compatibility typecheck)npm test— 513 passednpm run check:obsidian-compatnpm run test:e2e -- --provider gitea— 7 passedOfficial scanner follow-up
The shared CI workflow has no local official-marketplace scanner command. Re-run the external official scan after this PR is submitted. If it still reports E2E/tooling hits, document them as scanner-scope findings rather than rewriting valid Node tooling.