fix(scanner): remove Node E2E source - #120
Merged
Merged
Conversation
|
Member
Author
|
🎉 This PR is included in version 1.5.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the in-repository Node-only real-provider E2E harness so the Obsidian scanner no longer treats it as plugin source. Deletes the E2E runner and Vitest config, removes
test:e2e, and retains only the Node ESLint override required by the compatibility build script.The current CI and build-artifact workflow are unchanged. Long-term E2E architecture remains undecided.
Scanner audit
docs/obsidian-scanner-audit.mdmaps the reported baseline findings and the post-removal runtime/artifact audit. Shipping provider HTTP remains routed throughBaseGitService.safeRequest()and ObsidianrequestUrl().Validation
npx eslint .npm run buildnpx vitest run— 35 files, 509 testsmain.jscontains nonode:crypto,node:child_process, ornode:utilimportsA
fixcommit lets the established semantic-release workflow publish 1.5.7 after this PR is merged tomain.