Skip to content

sdk_lib: add GPG signature verification for SDK downloads #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prayag0one4 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

sdk_lib: add GPG signature verification for SDK downloads #4206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions sdk_lib/sdk_util.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ sdk_download_tarball() {
local server url suffix
local -a suffixes

suffixes=('' '.DIGESTS') # TODO(marineam): download .asc
suffixes=('' '.DIGESTS' '.DIGESTS.asc')
for server in "${FLATCAR_SDK_SERVERS[@]}"; do
url="${server}/sdk/${FLATCAR_SDK_ARCH}/${FLATCAR_SDK_VERSION}/${FLATCAR_SDK_TARBALL}"
info "URL: ${url}"
Expand Down Expand Up @@ -72,11 +72,16 @@ _sdk_check_downloads() {

sdk_verify_digests() {
if [[ ! -f "${FLATCAR_SDK_TARBALL_PATH}" || \
! -f "${FLATCAR_SDK_TARBALL_PATH}.DIGESTS" ]]; then
! -f "${FLATCAR_SDK_TARBALL_PATH}.DIGESTS" || \
! -f "${FLATCAR_SDK_TARBALL_PATH}.DIGESTS.asc" ]]; then
return 1
fi

# TODO(marineam): Add gpg signature verification too.
info "Verifying GPG signature of the DIGESTS file..."
if ! gpg --verify "${FLATCAR_SDK_TARBALL_PATH}.DIGESTS.asc" "${FLATCAR_SDK_TARBALL_PATH}.DIGESTS"; then
error "GPG signature verification failed! The SDK artifact may be compromised."
return 1
fi

verify_digests "${FLATCAR_SDK_TARBALL_PATH}" || return 1
}
Expand Down