Default Last-Event-ID resume to opt-in - #6
Merged
Merged
Conversation
Set resume off by default to align with curl/wget expectations, add an explicit --resume flag for opt-in behavior, and document the updated semantics in README. Add config tests covering the new default and resume override parsing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Simplify resume controls by keeping only --resume as the CLI override while preserving config-based enablement. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Replace the custom --resume switch with --continue and -c for familiar CLI behavior while keeping config-based resume control. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Accept continue= in .ssecatrc and document it as the primary key to match --continue/-c, while keeping resume= for backward compatibility. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove backward compatibility for resume= in .ssecatrc so only continue= is accepted. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
ssecatto match curl/wget-style expectations where resume is not assumed by default.What changed
resume=false.--resumeCLI flag so users can explicitly enable Last-Event-ID resume per run.--no-resumeas an explicit disable override.resume=false) and parsing override (resume=true).Notes for reviewers
The reconnect behavior itself is unchanged. This PR only changes the default for persisted Last-Event-ID resume and the CLI surface to opt in explicitly.