Skip to content

Include wrapper configs in buildscript - #86

Closed
Kichura wants to merge 1 commit into
florianreuth:mainfrom
Kichura:rs_fun
Closed

Include wrapper configs in buildscript#86
Kichura wants to merge 1 commit into
florianreuth:mainfrom
Kichura:rs_fun

Conversation

@Kichura

@Kichura Kichura commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

From the updated source code:

// HACK: Gradle overwrites all customized wrapper configurations,
// Meaning we have to include them in buildscript to make them persistent.
// (Source: https://github.com/gradle/gradle/issues/36172)

@florianreuth

Copy link
Copy Markdown
Owner

I have the same opinion as RK here. I would only override default values if we actually have situations or reproducable steps where changing them helps, especially when it gets hacky. Same rules apply for GH actions from now on, as I want to keep configurations as small as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants