urlize: escape text once and isolate mail linking - #383
Open
codexagents wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urlizeautoescape is enabledWhy
The current two-pass replacement first emits URL anchors and then applies the email regexp to that generated HTML. An email-shaped substring inside a URL can therefore be replaced inside the new
href. In addition, autoescape only covers matched URL titles; unmatched input is returned inside anAsSafeValueunchanged.Building the result from alternating text and URL runs makes provenance explicit. Each raw text/title run is escaped at most once, and generated markup is never scanned as input.
Verification
go test ./...go test -race ./...go vet ./...