feat: PR CI 워크플로우 추가 - #266
Merged
Merged
Conversation
pull_request 트리거로 lint/test/build 자동 검증. deploy.yml과는 별도 관심사로 분리 유지. Closes #265
BcKmini
added
area:platform
CI에서 처음으로 잡힘 — 클릭 핸들러의 비동기 체인(fetch→navigate)이 끝나기 전에 getByText로 동기 단언해서 타이밍에 따라 실패하던 문제. findByText로 교체.
Member
Author
|
첫 CI 실행에서 바로 pre-existing flaky 테스트 하나 잡음: `LinkRequestPage.test.tsx` "keeps the token when navigating to the upload page" — 클릭 핸들러의 비동기 체인(fetch→navigate)이 끝나기 전에 `getByText`로 동기 단언해서 타이밍에 따라 실패하던 레이스 컨디션. 로컬에선 우연히 안 걸렸음. `findByText`(polling)로 교체해서 수정, 재실행 확인함. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
뭘 했나
PR에 lint/test/build 자동 검증 워크플로우(
ci.yml) 추가. 지금까진deploy.yml하나뿐이라 PR이 검증 없이 머지되고 바로 배포까지 이어지는 구조였음.로컬 확인
npm run lint— 통과npm run test— 351 tests passed (71 files)npm run build— 성공 (청크 사이즈 경고만 있음, 에러 아님)deploy.yml은 건드리지 않음.
Closes #265