Skip to content

Fix Code Link delete button in dark mode - #683

Merged
huntercaron merged 1 commit into
mainfrom
fix/code-link-dark-delete-button
Aug 5, 2026
Merged

Fix Code Link delete button in dark mode#683
huntercaron merged 1 commit into
mainfrom
fix/code-link-dark-delete-button

Conversation

@huntercaron

@huntercaron huntercaron commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Description

Fix the Code Link deletion confirmation button so its destructive red styling is not overridden by Framer's dark-mode primary button styles. This also simplifies copy so it fits on two lines.

Screenshot 2026-08-05 at 11 42 54

Changelog

  • Keep the Code Link deletion confirmation button red and legible in dark mode.

Testing

  • Verify the deletion confirmation modal in dark mode
    • Open Code Link and trigger a local file deletion confirmation
    • Verify the modal looks correct
    • Verify the Delete button text is legible

Copilot AI review requested due to automatic review settings August 5, 2026 09:39
@github-actions github-actions Bot added the Auto submit to Marketplace on merge Submits the plugin to the marketplace after merging label Aug 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Code Link deletion confirmation UX so the destructive “Delete” action retains its intended styling in dark mode, and slightly simplifies single-file deletion copy.

Changes:

  • Simplifies the single-file deletion confirmation description text.
  • Adds dark-theme-specific CSS overrides for .framer-button-primary.destructive-button to preserve destructive background styling.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
plugins/code-link/src/App.tsx Updates single-file deletion confirmation copy.
plugins/code-link/src/App.css Adds dark-mode-specific styling overrides for the destructive primary button.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins/code-link/src/App.css
@huntercaron
huntercaron added this pull request to the merge queue Aug 5, 2026
Merged via the queue into main with commit f110f96 Aug 5, 2026
13 of 14 checks passed
@huntercaron
huntercaron deleted the fix/code-link-dark-delete-button branch August 5, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto submit to Marketplace on merge Submits the plugin to the marketplace after merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants