fix: uploaded image overwrites an earlier one with the same filename - #751
Open
kaulith wants to merge 2 commits into
Open
fix: uploaded image overwrites an earlier one with the same filename#751kaulith wants to merge 2 commits into
kaulith wants to merge 2 commits into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pasted clipboard images were all saved as
image.png, so their WebP versions were saved to the same/files/image.webpand overwrote previous images. One site had 26 File records pointing to the same URL.The WebP filename now goes through
generate_file_name, like normal Frappe uploads, to ensure each image gets a unique name.file_urlandfile_nameare also updated to match the file actually saved.Previously overwritten images cannot be recovered and need to be re-uploaded.
Screen.Recording.2026-08-27.at.2.03.03.PM.mov
Ref: https://support.frappe.io/helpdesk/tickets/76287?view=VIEW-HD+Ticket-1252