Skip to content

fix(sidebar): occlude rows below sticky headers #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brsbl wants to merge 3 commits into
base: main
Choose a base branch
from
+32 −2
Open

fix(sidebar): occlude rows below sticky headers #2396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45ebd59
fix(sidebar): occlude rows below sticky headers
brsbl Aug 25, 2026
f401c3f
fix(sidebar): blur translucent sticky headers
brsbl Aug 25, 2026
3a8820e
fix(sidebar): constrain sticky header blur
brsbl Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/app/src/components/ui/theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@
min-height: var(--bb-sidebar-sticky-tier-height);
z-index: var(--bb-sidebar-sticky-tier-z-index);
isolation: isolate;
/* Native vibrancy can make a sidebar paint translucent. The image keeps
opaque themes unchanged. The shield below blurs rows beneath a
translucent tier instead of letting them collide with its label. */
background-image: linear-gradient(var(--sidebar), var(--sidebar));
}

[data-sidebar-sticky-stack] [data-sidebar-sticky-tier]::before,
Expand All @@ -202,11 +206,14 @@
z-index: -1;
pointer-events: none;
background-color: var(--sidebar);
background-image: linear-gradient(var(--sidebar), var(--sidebar));
backdrop-filter: blur(16px);
}

[data-sidebar-sticky-stack] [data-sidebar-sticky-tier]::before {
bottom: 100%;
height: var(--bb-sidebar-sticky-tier-shield-top-height, 0);
top: calc(-1 * var(--bb-sidebar-sticky-tier-shield-top-height, 0));
bottom: auto;
height: calc(100% + var(--bb-sidebar-sticky-tier-shield-top-height, 0));
}

[data-sidebar-sticky-stack] [data-sidebar-sticky-tier]::after {
Expand Down
23 changes: 23 additions & 0 deletions apps/app/src/components/ui/theme.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,29 @@ function contrastRatio(foreground: OklchColor, background: OklchColor): number {
}

describe("theme.css neutral ramp", () => {
it("prevents rows from reading through every sticky sidebar tier", () => {
const rule = css.match(
/\[data-sidebar-sticky-stack\] \[data-sidebar-sticky-tier\]\s*\{([^}]*)\}/s,
)?.[1];

expect(rule).toContain(
"background-image: linear-gradient(var(--sidebar), var(--sidebar));",
);
expect(rule).not.toContain("backdrop-filter");

const shieldRule = css.match(
/\[data-sidebar-sticky-stack\] \[data-sidebar-sticky-tier\]::before,\s*\[data-sidebar-sticky-stack\] \[data-sidebar-sticky-tier\]::after\s*\{([^}]*)\}/s,
)?.[1];
expect(shieldRule).toContain("backdrop-filter: blur(16px);");

const topShieldRule = css.match(
/\[data-sidebar-sticky-stack\] \[data-sidebar-sticky-tier\]::before\s*\{([^}]*)\}/s,
)?.[1];
expect(topShieldRule).toContain(
"100% + var(--bb-sidebar-sticky-tier-shield-top-height, 0)",
);
});

it("backs selected sticky sidebar rows with an opaque sidebar layer", () => {
const rule = css.match(
/\[data-sidebar-sticky-tier\]\.bb-sidebar-selected-row\s*\{([^}]*)\}/s,
Expand Down
Loading