Bound plugin pages and add experimental panel menus - #2405
Open
brsbl wants to merge 5 commits into
Open
Conversation
brsbl
changed the base branch from
bb/sidebar-structure-thr_3zy8th6zyc
to
main
August 25, 2026 15:50
brsbl
changed the base branch from
main
to
bb/sidebar-structure-thr_3zy8th6zyc
August 25, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Plugin pages used two overlapping persistence concepts—an order and a hidden set—while the sidebar rendered every non-hidden page without a cap. That let plugin-heavy installs crowd threads out of the column and gave keyboard users no route to split a plugin page or reach plugin-contributed actions.
The first hidden-page migration did not preserve the old UI's felt state. Legacy “Hide from sidebar” rows lived behind
More (N), but the migration used the ordinary five-row cap and therefore resurfaced hidden pages when an installation had five or fewer plugin pages. It also cleared the entire legacy hidden set, even though the host-owned__builtin__/toolsentry belongs to the later top-region toggle migration.What changed
Show N moredisclosure.Move to top/Move to overflow, cross-cap reordering, split, and plugin-settings actions through one menu definition shared by the ellipsis button and right-click.__builtin__/toolsnever enter plugin order or overflow and remain in the legacy atom for the toggles layer to consume.experimental_menuplugin-app contract, including up to four labeled groups, one lazy submenu level, contained action/resolver failures, unknown-icon tolerance, and context helpers for navigation and splits.HOST_DAEMON_PROTOCOL_VERSIONis unchanged.UI evidence
Identical fixture and viewport in both images: four plugin pages, with GitHub and Docs present in the legacy hidden set before first paint. The crop excludes unrelated project data.
Before — merge base
c781d323eThe same two pages are visible and the two hidden pages remain parked behind
More (2).After — PR head
c3612aae6The same two pages remain visible, while the migrated disclosure uses the new
Show 2 morelabel.The immutable screenshot assets are pinned to fork commit
55df2709a481b35ad360cea930ea3fa4646c2a7d; both raw URLs return HTTP 200 withimage/png.How you verified
@bb/host-watchernested-directory event test timed out waiting for a macOS filesystem event; an isolated retry reproduced that one timeout after its other 45 tests passed.@bb/process-utils, whose macOS cwd tests require/usr/sbin/lsof, passed 20/20 in an isolated Node 22 run. No Task 1 file touches either package.c3612aae6, including all app, package, server, integration, package-smoke, version-lockstep, and SDK-version guards.Fixes
No linked issue; implements Phase 3 layer 1 of the Updated Sidebar Spec on top of PR #2395.
BB-Thread-ID: thr_jgmy8ay2qd
BB-Thread-ID: thr_2e2gbjx943