Prevent concurrent servers from sharing a data directory - #2423
Open
ymichael wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The server had no data-directory singleton lock. During overlapping dev restarts, a second server could open the same SQLite database before losing its port bind. Because in-flight provisioning context is process-local, startup recovery in that second process could treat a live starting thread as orphaned and emit a false
thread_provisioning_failedevent.What changed
@bb/process-utilsdata-directory lock module, including stale-lock recovery and compromise handling.server.lockacquired before logger creation,initDb(), and startup recovery.HOST_DAEMON_PROTOCOL_VERSIONis unchanged.How you verified
initDb(), reclaiming a fresh orphaned server lock, releasing ownership after startup failure, releasing during compromise re-acquisition, and retaining exit cleanup through asynchronous unlock.pnpm exec turbo run test --filter=@bb/server --force— 2,037 tests passed.pnpm exec turbo run test --filter=@bb/host-daemon --force— 557 tests passed.pnpm exec turbo run test --filter=@bb/process-utils --force— 25 tests passed.pnpm exec turbo run typecheck --filter=@bb/process-utils --filter=@bb/server --filter=@bb/host-daemonpassed.pnpm exec turbo run build --filter=@bb/server --filter=@bb/host-daemonpassed.node packages/plugin-sdk/scripts/check-npm-version-guard.mjspassed.Related to #2190: prevents concurrent bb server access to the database directory, but does not resolve the WAL durability/reversion issue.
Fixes: no linked issue.