Disable the Monaco editor by default and rename it to File Editor - #2439
Merged
SawyerHood merged 2 commits intoAug 25, 2026
Merged
Conversation
The builtin from #2127 replaced the read-only file preview for ~86 extensions on every fresh install. Ship it opt-in instead: flip defaultEnabled to false so a fresh database registers it disabled. Existing registrations keep their stored enabled state. Rename the user-facing strings to "File Editor": the manifest bb.name shown in Settings > Plugins and the fileOpener title shown in Settings > File openers. The plugin id monaco-editor and the opener id monaco stay, so existing rows and per-extension opt-outs still match. Co-Authored-By: Claude <noreply@anthropic.com>
The smoke waits for every default-enabled builtin to reach "running". The File Editor now ships disabled, so the wait timed out on monaco-editor=disabled. Remove it from the list; the list documents itself as the default-enabled set. Co-Authored-By: Claude <noreply@anthropic.com>
SawyerHood
deleted the
bb/disable-monaco-plugin-by-default-thr_hrj23849f7
branch
August 25, 2026 23:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
#2127 shipped the Monaco builtin with
defaultEnabled: true. On a fresh install it replaces the read-only file preview for ~86 text extensions without the user opting in. Its user-facing name also described the engine (Monaco) rather than what it does in BB.What changed
apps/server/src/services/plugins/builtin-registry.ts:monaco-editornow hasdefaultEnabled: false. A fresh database registers it disabled. Existing registrations keep their storedenabledstate because reconciliation usesexisting?.enabled ?? bundled.defaultEnabled, so this does not turn it off for users who already have it.plugins/monaco-editor/package.json: manifestbb.nameis nowFile Editor(Settings > Plugins, plugin store).plugins/monaco-editor/app.tsx: thefileOpenertitleis nowFile Editor(Settings > File openers).monaco-editor, the directory, the package name, and the opener idmonacodo not change, so existing registration rows and per-extension opt-outs still match.packages/bb-app/scripts/smoke-tarball.mjs:monaco-editorleavesEXPECTED_RUNNING_BUILTIN_PLUGINS. That list is the default-enabled set the package smoke waits on, and a disabled plugin never reachesrunning.No wire changes. No CLI or doc surfaces name the plugin.
How you verified
ships the File Editor (monaco-editor) disabled on a fresh databasetoapps/server/test/services/plugins/builtin-plugins.test.ts. It fails onmain(defaultEnabledistrue) and passes here.pnpm exec turbo run test --filter=@bb/server -- test/services/plugins/builtin-plugins.test.ts test/services/plugins/official-plugins.test.ts: 34/34 pass.pnpm exec turbo run test typecheck --filter=bb-plugin-monaco-editor: typecheck clean, 11/11 pass.HEAD, andorigin/main..HEAD: clean.