Fix path dialogs, shell-search inference, and toast dismissal - #2441
Open
SawyerHood wants to merge 1 commit into
Open
Fix path dialogs, shell-search inference, and toast dismissal#2441SawyerHood wants to merge 1 commit into
SawyerHood wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Three small, independent problems from mbullington's
agent/garden-upstream-stack, rebased ontomain:grep/rg, so an unrelated bash call rendered as a search row.AppToastContentnever rendered one for custom content.What changed
apps/apppath dialogs anduseLocalPathPickertake the selected host's platform;HostResponseexposes it (packages/server-contract/src/api/hosts.ts,packages/sdk/src/areas/hosts.ts). Offline hosts fall back to the prop platform.packages/thread-view/src/tool-call-parsing.tsstops inferring search intents from shell text; tests and CLI rendering snapshots updated. The handoff notes live inplans/pi-session-tool-precedence-and-search-intents.md.apps/app/src/main.tsxenables Sonner'scloseButton;AppToastContentrenders its own dismiss X.No wire change. Bottom of the stack: no prerequisite.
How you verified
pnpm exec turbo run typecheckon this layer, plusturbo run testfor@bb/app,@bb/server,@bb/server-contract,@bb/sdk,@bb/thread-view,@bb/mobile,@bb/host-daemon(see the stack validation log in the thread).Fixes: none (upstream stack split).