Add sidebar-navigation and Changes-view replacement slots - #2443
Open
SawyerHood wants to merge 1 commit into
Open
Add sidebar-navigation and Changes-view replacement slots#2443SawyerHood wants to merge 1 commit into
SawyerHood wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Plugins could replace the thread list but not the two other sidebar/secondary-panel surfaces people wanted to own: the navigation controls block (New thread / Search / Extensions / plugin panels) and the whole Changes view (toolbar + file list). Plugin-owned dialogs also lacked a host-provided non-modal drawer.
What changed
Two exclusive replacement slots and one helper, all
experimental_and entered indocs/api_to_audit.md:app.slots.experimental_sidebarNavigation: a semantic item list (new-thread,search-threads,extensions,plugin-panel:<pluginId>/<panelId>),activeItemId,experimental_activate(itemId, { openInSplit }),experimental_Original. bb keeps the drawer, search field, thread list, footer, and shortcuts (SidebarNavigationRegion,sidebarNavigationItems.ts). Settings → Appearance → Navigation picks the provider.app.slots.experimental_changesView: replaces the Changes toolbar and file list;ChangesViewHostpassesexperimental_target(file/commit intents with a sequence) andexperimental_Original. The built-in view remembers its selection per environment and its line-overflow mode.experimental_ResponsiveDrawer(PluginResponsiveDrawer): the shared persistent responsive drawer for plugin UIs.PluginSourceCodeRendererProps.experimental_Original/PluginDiffRendererProps.experimental_Original.plugin-app-collector,plugin-slots, the testing harness, and thereplacement-lab-*example plugins cover the new slots.No wire change. Prerequisite: #2442 (stack order only).
How you verified
turbo run typecheck;turbo run testfor@get-bb/plugin-sdk,@bb/app(sidebar, secondary-panel, settings, plugin),@bb/server(plugin-authoring docs),@bb/cli(packaged plugin build with the examples).Fixes: none (upstream stack split).