Carry provider extension UI through the bridge, daemon, server, and app - #2446
Open
SawyerHood wants to merge 1 commit into
Open
Carry provider extension UI through the bridge, daemon, server, and app#2446SawyerHood wants to merge 1 commit into
SawyerHood wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
A provider plugin's extensions (pi's
ctx.ui) had no generic path into bb: no thread-scoped questions outside a turn, no way to cancel them, no persisted per-thread extension state with app-rendered actions, no bridge-listed slash commands, and no plugin-to-bridge RPC.What changed (no Pi code in this layer)
interaction/requestmay carryturnId: null+experimental_scope: "thread";interaction/cancelnotification;command/list;provider/custom;extension/action(packages/provider-bridge-protocol,packages/agent-runtime).experimental_responseMode: "verbatim",experimental_placeholder,experimental_prefill, answers withexperimental_verbatimText;USER_QUESTION_MAX_OPTIONS4 → 100 (packages/domain/src/pending-interactions.ts). App and mobile question forms honor verbatim mode.host.list_commandsmerges the bridge'scommand/list(withdiagnostics);provider.custom_call;thread.extension-state.action; per-interaction abort registry.extension.statesnapshots (thread/extensionState/updated, superseded-event pruning), exposesextensionStateson the timeline,POST …/extension-state/action;bb.providers.experimental_client/experimental_modelsChanged(per-host model cache invalidation);PluginSettingsSectionProps.experimental_hostId.app.slots.experimental_providerExtensionStaterenders a provider's state kinds above/below the composer.HOST_DAEMON_PROTOCOL_VERSION171 → 172.docs/provider-bridge-protocol.mdanddocs/api_to_audit.mdupdated.Prerequisite: #2445 (shares the protocol header and
routes/threads/actions.ts).Known gaps, deliberate: dialogs are thread-scoped even mid-turn; cancel is thread-wide; no runtime-level test for
interaction/cancelwiring.How you verified
turbo run typecheck;turbo run testfor@bb/agent-runtime,@bb/provider-bridge-protocol,@bb/host-daemon,@bb/server(interactions, extension-state action, project commands, model cache),@bb/app,@bb/mobile,@bb/db,@bb/domain,@bb/thread-view,@get-bb/plugin-sdk,bb-plugin-provider-codex,@bb/host-daemon-contract.Fixes: none (upstream stack split).