fix(dashboards): Remove references to removed datasets - #1515
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
left a comment
There was a problem hiding this comment.
I think you should merge this one with your other PR
|
Jared, take over the PR, address all bot comments, address all review comments and get it merged |
|
taking this over. current state of #1515:
the code here is complete. the one thing i can't resolve on my own: #1516 (the alerts half of BROWSE-682) is still a draft with an open design thread — route how do you want #1515 handled?
happy to merge immediately on a 👍 — just don't want to break the "merge these together" intent by shipping #1515 while #1516 is still in draft. |
discoverandtransactionsare no longer valid datasets for dashboard widgets (the same use cases are supported byerrorsandspans). All existing dashboards have been migrated off of those datasets and creating new widgets that use them has been blocked on all billing plans.Remove all references to
discoverandtransactionsdatasets from dashboard code and skills. Also removes transaction-specific aggregate functions fromDISCOVER_AGGREGATE_FUNCTIONS(nowERROR_AGGREGATE_FUNCTIONS, as that is the only dataset left that supports them).See BROWSE-682.