Skip to content

fix(dashboards): Remove references to removed datasets - #1515

Merged
BYK merged 1 commit into
mainfrom
mjq/remove-dashboard-transactions-discover
Sep 4, 2026
Merged

BYK merged 1 commit into
mainfrom
mjq/remove-dashboard-transactions-discover

Conversation

@mjq

@mjq mjq commented Aug 31, 2026 •

Copy link
Copy Markdown
Member

discover and transactions are no longer valid datasets for dashboard widgets (the same use cases are supported by errors and spans). All existing dashboards have been migrated off of those datasets and creating new widgets that use them has been blocked on all billing plans.

Remove all references to discover and transactions datasets from dashboard code and skills. Also removes transaction-specific aggregate functions from DISCOVER_AGGREGATE_FUNCTIONS (now ERROR_AGGREGATE_FUNCTIONS, as that is the only dataset left that supports them).

See BROWSE-682.

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cli Ready Ready Preview Aug 31, 2026 4:17pm

Request Review

@BYK BYK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should merge this one with your other PR

@linear-code

linear-code Bot commented Aug 31, 2026

Copy link
Copy Markdown

BROWSE-682

@BYK
BYK marked this pull request as ready for review September 4, 2026 09:38
@BYK BYK added the jared Trigger the Jared agent to work on stuff label Sep 4, 2026
@BYK

BYK commented Sep 4, 2026

Copy link
Copy Markdown
Member

Jared, take over the PR, address all bot comments, address all review comments and get it merged

@jared-outpost

jared-outpost Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

taking this over. current state of #1515:

the code here is complete. the one thing i can't resolve on my own: #1516 (the alerts half of BROWSE-682) is still a draft with an open design thread — route transaction(s) → spans with is_transaction:true plus a gentle nudge — and that routing isn't implemented yet. since these files don't overlap, merging is safe either way; the question is timing.

how do you want #1515 handled?

  1. merge it now independently (it's ready), or
  2. hold it and land both together once fix(alerts): Remove deprecated transactions dataset #1516's routing + nudge work is done (i'll pick that up under fix(alerts): Remove deprecated transactions dataset #1516's take-over).

happy to merge immediately on a 👍 — just don't want to break the "merge these together" intent by shipping #1515 while #1516 is still in draft.

@BYK
BYK merged commit 657a194 into main Sep 4, 2026
35 checks passed
@BYK
BYK deleted the mjq/remove-dashboard-transactions-discover branch September 4, 2026 15:09

This branch was successfully deployed

1 active deployment
Preview — 3c30089b Deployed Aug 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jared Trigger the Jared agent to work on stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants