fix(explore): Remove deprecated transaction dataset - #1573
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cfd1c72. Configure here.
| /** Default fields when none specified — top errors view */ | ||
| const DEFAULT_FIELDS = ["title", "count()"]; | ||
| const DEFAULT_TRANSACTION_FIELDS = ["transaction", "count()"]; | ||
| const TRANSACTION_DATASET = "transactions"; |
There was a problem hiding this comment.
wait, weren't we removing this dataset??
There was a problem hiding this comment.
...oh, it's already gone. I was trying to replicate what was done in #1516 (resolveEventsDataset routes transaction(s) requests to the spans dataset) but you're right, since this dataset was already removed from the explore surface there's no backwards compat to maintain. I'll just get rid of this again.
There was a problem hiding this comment.
I mean we can support the mapping of transactions to span dataset mapping but this mapped transaction to transactions or something like that?
There was a problem hiding this comment.
It's just a sentinel value for the downstream code to know to treat it differently (spans dataset query with is_transaction:true added to it)
There was a problem hiding this comment.
Could also try to find a way to remove it from this hash and make the separate code path obvious, agree it's misleading as is
This branch was successfully deployed
2 participants
Remove calls to the deprecated/unsupported
transactionsdataset from theexploresurface area.Following the lead of #1516, you can still ask to explore
transaction(s)and we'll route you tospanswithis_transaction:trueto smooth out the transition for users.Fixes BROWSE-682.