Skip to content

fix(span): use ResolutionError for missing spans #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 1 commit into from
Sep 25, 2026
Merged

fix(span): use ResolutionError for missing spans #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions packages/cli/src/commands/span/view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ import {
} from "../../lib/api-client.js";
import { spansFlag } from "../../lib/arg-parsing.js";
import { buildCommand } from "../../lib/command.js";
import { ContextError, ValidationError } from "../../lib/errors.js";
import {
ContextError,
ResolutionError,
ValidationError,
} from "../../lib/errors.js";
import {
type FoundSpan,
findSpanById,
Expand Down Expand Up @@ -430,11 +434,10 @@ export const viewCommand = buildCommand({
const spans = await getDetailedTrace(org, traceId);

if (spans.length === 0) {
throw new ValidationError(
`No trace found with ID "${traceId}".\n\n` +
"The ID format is valid but no matching trace exists in this project. " +
"Check that you are querying the right org/project, or the trace may be past your plan's retention window."
);
throw new ResolutionError(`Trace "${traceId}"`, "not found", USAGE_HINT, [
"The ID format is valid but no matching trace exists in this project",
"Check that you are querying the right org/project, or the trace may be past your plan's retention window",
]);
}

// Find each requested span
Expand All @@ -455,11 +458,19 @@ export const viewCommand = buildCommand({
}

if (results.length === 0) {
if (spanIds.length === 1) {
throw new ResolutionError(
`Span "${spanIds[0]}" in trace ${traceId}`,
"not found",
USAGE_HINT
);
}
const idList = formatIdList(spanIds);
throw new ValidationError(
spanIds.length === 1
? `No span found with ID "${spanIds[0]}" in trace ${traceId}.`
: `No spans found with any of the following IDs in trace ${traceId}:\n${idList}`
throw new ResolutionError(
`Spans in trace ${traceId}`,
"none of the requested IDs were found",
USAGE_HINT,
[`Requested IDs:\n${idList}`]
);
}

Expand Down
18 changes: 11 additions & 7 deletions packages/cli/test/commands/span/view.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ vi.mock("../../../src/lib/api-client.js", async (importOriginal) => {
import * as apiClient from "../../../src/lib/api-client.js";
import { DEFAULT_SENTRY_URL } from "../../../src/lib/constants.js";
import { setOrgRegion } from "../../../src/lib/db/regions.js";
import { ContextError, ValidationError } from "../../../src/lib/errors.js";
import {
ContextError,
ResolutionError,
ValidationError,
} from "../../../src/lib/errors.js";
import { validateSpanId } from "../../../src/lib/hex-id.js";

vi.mock("../../../src/lib/resolve-target.js", async (importOriginal) => {
Expand Down Expand Up @@ -414,7 +418,7 @@ describe("viewCommand.func", () => {
expect(output).toContain("http.server");
});

test("throws ValidationError when trace has no spans", async () => {
test("throws ResolutionError when trace has no spans", async () => {
getDetailedTraceSpy.mockResolvedValue([]);

const { context } = createContext();
Expand All @@ -429,10 +433,10 @@ describe("viewCommand.func", () => {
VALID_TRACE_ID,
VALID_SPAN_ID
)
).rejects.toThrow(ValidationError);
).rejects.toThrow(ResolutionError);
});

test("throws ValidationError when span ID not found in trace", async () => {
test("throws ResolutionError when span ID not found in trace", async () => {
getDetailedTraceSpy.mockResolvedValue([makeTraceSpan("0000000000000000")]);

const { context } = createContext();
Expand All @@ -447,7 +451,7 @@ describe("viewCommand.func", () => {
VALID_TRACE_ID,
VALID_SPAN_ID
)
).rejects.toThrow(ValidationError);
).rejects.toThrow(ResolutionError);
});

test("uses explicit org/project from slash-separated arg", async () => {
Expand Down Expand Up @@ -545,7 +549,7 @@ describe("viewCommand.func", () => {
).rejects.toThrow(ContextError);
});

test("throws ValidationError for multiple missing span IDs", async () => {
test("throws ResolutionError for multiple missing span IDs", async () => {
getDetailedTraceSpy.mockResolvedValue([makeTraceSpan("0000000000000000")]);

const { context } = createContext();
Expand All @@ -558,6 +562,6 @@ describe("viewCommand.func", () => {
VALID_SPAN_ID,
VALID_SPAN_ID_2
)
).rejects.toThrow(ValidationError);
).rejects.toThrow(ResolutionError);
});
});
Loading