Skip to content

fix(install): use release registry with GitHub fallback - #1637

Merged
BYK merged 1 commit into
mainfrom
bt/fix-installer-release-discovery
Sep 28, 2026
Merged

BYK merged 1 commit into
mainfrom
bt/fix-installer-release-discovery

Conversation

@betegon

@betegon betegon commented Sep 28, 2026

Copy link
Copy Markdown
Member

Summary

A fresh curl install can abort before downloading the CLI when GitHub's anonymous latest-release API returns 403. Resolve the latest stable version from Sentry's existing Craft release registry first, with GitHub as a fallback when the registry request fails, times out, or returns an invalid version.

Limit each metadata request to 10 seconds and show an actionable error with the existing --version override if both sources fail. Binary downloads continue to use versioned GitHub Releases assets.

Test plan

  • pnpm exec vitest run test/lib/install-script.test.ts — 23 passed, including registry success with GitHub blocked, fallback, both sources failing, large responses, and pinned-version bypass.
  • pnpm exec biome check --write test/lib/install-script.test.ts, bash -n packages/cli/install, and git diff --check passed.
  • Real macOS ARM64 and Debian ARM64 installs with the registry blocked succeeded through the GitHub fallback; the installed binary passed --version and --help.
  • Full suite/build and other platforms were not run.

@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cli Ready Ready Preview Sep 28, 2026 8:19am UTC
1 Skipped Deployment
Project Deployment Actions Updated
sentry-local Skipped Skipped Sep 28, 2026 8:19am UTC

Request Review

@BYK
BYK marked this pull request as ready for review September 28, 2026 08:42
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Sep 28, 2026
@BYK
BYK merged commit 8730d25 into main Sep 28, 2026
36 checks passed
@BYK
BYK deleted the bt/fix-installer-release-discovery branch September 28, 2026 08:47

This branch was successfully deployed

1 active and 1 inactive deployments
Preview – cli — 1db87e81 Deployed Sep 28, 2026 by vercel[bot]
Preview – sentry-local — 1db87e81 Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants