chore(lint): require target resolution helpers - #1641
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1622. CLI commands should resolve project/org targets through the capability helpers in
resolve-target.ts; callingfindProjectsBySlug()or the old miss classifier directly lets command-specific precedence drift.This adds a Biome Grit rule for
src/commands/**that rejects direct low-level target lookup, including namespace-style calls.commands/issue/utils.tsis explicitly excluded because its project lookup is part of issue-ID resolution, not CLI target parsing.The command-layer boundary is also documented in
AGENTS.mdso the diagnostic points contributors to the intended architecture.Test plan
pnpm run lintpnpm exec tsc --noEmitfindProjectsBySlug()produces the new plugin diagnosticcommands/issue/utils.tsremains acceptedMade with Cursor