feat(core): Instrument workers-ai-provider#22119
Draft
JPeer264 wants to merge 1 commit into
Draft
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a22515d. Configure here.
| }) as T; | ||
|
|
||
| instrumentedClients.add(instrumented); | ||
| return instrumented; |
There was a problem hiding this comment.
WeakSet misses original client
Medium Severity
instrumentWorkersAiClient only registers the proxy in instrumentedClients, not the binding passed in. A second call with the same original env.AI (or manual wrap after auto instrumentation) is not recognized and wraps again, so each run can emit nested spans.
Reviewed by Cursor Bugbot for commit a22515d. Configure here.
|
|
||
| instrumentedClients.add(instrumented); | ||
| return instrumented; | ||
| } |
There was a problem hiding this comment.
Missing integration or E2E test
Low Severity
This feature PR adds Workers AI instrumentation with unit tests only. Per SDK review guidelines, a feat change should include at least one integration or E2E test exercising the new tracing behavior end-to-end.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit a22515d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #20839
closes JS-2449
This is instrumenting
workers-ai, but it needs to be wrapped, as in Cloudflare there is no monkey patching for bindings. In a follow-up PR this will be included in theinstrumentEnvwithin Cloudflare.Tbh I would have added this into
packages/cloudflare, but all AI integrations do live in core, and there are also some utils which are only there and would have needed to export, such asendStreamSpanand all the gen-ai-attributes. The downside of this is that the workers-ai types needed to be vendored in (in thepackages/cloudflarewe could have taken them from the@cloudflare/workers-typespackage.