ref(nitro, nuxt): inline == null checks for nullish detection

[logaretm]

Adds an isNullish type guard to @sentry/core and replaces the identical isEmptyValue copies in @sentry/nitro and @sentry/nuxt storage instrumentation. Both were value === null || value === undefined with the same value is null | undefined guard, so this is behavior-neutral.

Named isNullish rather than isEmptyValue since it only checks nullishness, not emptiness.

[github-actions]

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	27.59 kB	-	-
@sentry/browser - with treeshaking flags	26.03 kB	-	-
@sentry/browser (incl. Tracing)	46.34 kB	-	-
@sentry/browser (incl. Tracing + Span Streaming)	48.13 kB	-	-
@sentry/browser (incl. Tracing, Profiling)	51.12 kB	-	-
@sentry/browser (incl. Tracing, Replay)	85.62 kB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	75.26 kB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	90.32 kB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	102.97 kB	-	-
@sentry/browser (incl. Feedback)	44.76 kB	-	-
@sentry/browser (incl. sendFeedback)	32.38 kB	-	-
@sentry/browser (incl. FeedbackAsync)	37.51 kB	-	-
@sentry/browser (incl. Metrics)	28.67 kB	-	-
@sentry/browser (incl. Logs)	28.91 kB	-	-
@sentry/browser (incl. Metrics & Logs)	29.59 kB	-	-
@sentry/react	29.38 kB	-	-
@sentry/react (incl. Tracing)	48.61 kB	-	-
@sentry/vue	33.02 kB	-	-
@sentry/vue (incl. Tracing)	48.31 kB	-	-
@sentry/svelte	27.61 kB	-	-
CDN Bundle	30 kB	-	-
CDN Bundle (incl. Tracing)	48.32 kB	-	-
CDN Bundle (incl. Logs, Metrics)	31.57 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics)	49.64 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics)	70.81 kB	-	-
CDN Bundle (incl. Tracing, Replay)	85.84 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	87.14 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback)	91.64 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	92.92 kB	-	-
CDN Bundle - uncompressed	89.35 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	146.1 kB	-	-
CDN Bundle (incl. Logs, Metrics) - uncompressed	94.05 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	150.07 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	218.78 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	265.3 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	269.26 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	279 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	282.95 kB	-	-
@sentry/nextjs (client)	51.16 kB	-	-
@sentry/sveltekit (client)	46.78 kB	-	-
@sentry/core/server	78.43 kB	-	-
@sentry/core/browser	64.76 kB	-	-
@sentry/node-core	62.72 kB	-0.01%	-1 B 🔽
@sentry/node	125.37 kB	-	-
@sentry/node (incl. diagnostics channel injection)	138.55 kB	+0.01%	+1 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)	69.95 kB	-	-
@sentry/node/light	50.72 kB	+0.01%	+1 B 🔺
@sentry/node - without tracing	74.06 kB	-	-
@sentry/aws-serverless	83.25 kB	-	-
@sentry/cloudflare (withSentry) - minified	181.71 kB	-	-
@sentry/cloudflare (withSentry)	449.16 kB	-	-

View base workflow run

[Lms24]

hmm maybe I'm missing something but can't we just replace all of these function call with inline wat == null checks? At least for the inverse (something != null) this works.

[logaretm]

@Lms24 I think that makes sense, I was thrown off by having a function that checks that already. Will normalize all to == since we have a lot of occurrences.