feat(core): add isObjectLike guard and consolidate non-null-object checks#22155
Merged
Conversation
Contributor
size-limit report 📦
|
…raphql-js convention
logaretm
changed the title
logaretm
requested review from
JPeer264,
Lms24,
andreiborza,
chargome,
mydea and
s1gr1d
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
isObjectLiketype guard to@sentry/core(typeof x === 'object' && x !== null) and routes the duplicated and inline non-null-object checks across the SDK through it.Named
isObjectLikerather thanisObjecton purpose. This guard only rules out null, primitives, and functions (arrays and class instances pass). I took a look at some examples in the ecosystem and GraphQL and Lodash do use this name for this exact type of check, so I'm sticking with that.