feat(snuba): add OP_REGEXP to EAP comparison filters - #420
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
Member
|
@pbhandari does 'string only' include |
pbhandari
force-pushed
the
feat/regexp-search
branch
from
September 8, 2026 18:09
ebc63e3 to
29e13a2
Compare
Contributor
Author
|
@MeredithAnya Yes it does. Updated the PR description to clarify. |
MeredithAnya
approved these changes
Sep 8, 2026
4 tasks
pbhandari
added a commit
to getsentry/snuba
that referenced
this pull request
Sep 10, 2026
## Problem EAP RPC comparison filters have no regexp op. Logs search ([LOGS-958](https://linear.app/getsentry/issue/LOGS-958)) is blocked on [EAP-739](https://linear.app/getsentry/issue/EAP-739/add-regexp-support-for-eap-rpc). Depends on sentry-protos [PR 420](getsentry/sentry-protos#420) (`OP_REGEXP` on ComparisonFilter / AnyAttributeFilter). ## Solution Translate `OP_REGEXP` in the shared EAP filter translator to ClickHouse `match()` (search-anywhere, RE2). - Same type rules as LIKE (string and string-array keys) - `ignore_case` → `match(lower(value), lower(pattern))` - Empty pattern → 400 - ClickHouse `CANNOT_COMPILE_REGEXP` (36) remapped to RPC 400 - AnyAttribute op dispatch is a `match` including REGEXP ## Validation `pytest tests/web/rpc/test_common.py::TestTraceItemFiltersRegexp` and related LIKE/any-attribute tests. ## Linear https://linear.app/getsentry/issue/EAP-739/add-regexp-support-for-eap-rpc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
OP_REGEXPto snuba EAP filters, mirroringOP_EQUALS/OP_LIKE.ComparisonFilter.Op.OP_REGEXP = 13(TYPE_STRING/TYPE_ARRAY_STRINGonly, RE2)AnyAttributeFilter.Op.OP_REGEXP = 7Snuba PR: getsentry/snuba#8437
Test plan
buf lint/buf breakingpassmatchfor this op