feat(tracing): Send sentry.segment.name.source instead of sentry.span.source attribute#6835
Conversation
…pan.source` attribute
Codecov Results 📊✅ 91854 passed | ⏭️ 6302 skipped | Total: 98156 | Pass Rate: 93.58% | Execution Time: 315m 53s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2478 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.68% 89.68% —%
==========================================
Files 193 193 —
Lines 24004 24004 —
Branches 8340 8340 —
==========================================
+ Hits 21526 21526 —
- Misses 2478 2478 —
- Partials 1387 1387 —Generated by Codecov Action |
| attributes={ | ||
| "sentry.origin": CeleryIntegration.origin, | ||
| "sentry.span.source": TransactionSource.TASK.value, | ||
| "sentry.segment.name.source": SegmentNameSource.TASK.value, |
There was a problem hiding this comment.
Seer pointed out that the "wrong" enum was used here (no big deal as the values were identical). So I changed it over to SegmentNameSource
|
Still need to take a look at the changes themselves but to initially answer your questions in the pull request summary:
As of right now I don't believe there are callbacks relying on this attribute so I think this should be a safe to do right now.
Since the underlying value hasn't changed, this isn't considered this breaking. 🚀 |
Co-authored-by: Erica Pisani <hey@ericapisani.dev>
Following the deprecation of
sentry.span.source, this PR renames the attribute fromsentry.span.sourcetosentry.segment.name.source.Background: We currently decided not do do segment name clustering for streamed spans but should we ever choose to do it,
sentry.segment.name.sourcewill be the attribute carrying the name source for it. Either way,sentry.span.sourcehas no effect anymore.Reviewers, please let me know about your preferences:
SegmentSourcetoSegmentNameSourcefor consistency. Is this considered breaking? If so, happy to revert as it's purely a cosmetic change IMHO.