fix(ios): Restore ObjC SentrySwizzle for RNSScreen to link against xcframework#6468
Open
alwx wants to merge 1 commit into
Open
fix(ios): Restore ObjC SentrySwizzle for RNSScreen to link against xcframework#6468alwx wants to merge 1 commit into
alwx wants to merge 1 commit into
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
…framework The Swift SPI enum case SentryInternalSwizzleApi.Mode.oncePerClass isn't exported as a linkable symbol from sentry-cocoa's prebuilt static xcframework, so consumers on the default SENTRY_USE_XCFRAMEWORK path fail to link. Route the RNSScreen viewDidAppear: swizzle back through the ObjC SentrySwizzle API, whose class symbols are exported in the xcframework slice. Fixes #6465.
alwx
force-pushed
the
fix/ios-xcframework-rnsscreen-swizzle-link
branch
from
July 20, 2026 08:38
74b4aae to
e4a99a6
Compare
alwx
marked this pull request as ready for review
July 20, 2026 08:42
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Restore ObjC SentrySwizzle for RNSScreen to link against xcframework ([#6468](https://github.com/getsentry/sentry-react-native/pull/6468))If none of the above apply, you can opt out of this check by adding |
📲 Install BuildsAndroid
|
Collaborator
|
Should we close this PR? it seems the root cause was done by user error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Restore the
SentrySwizzleObjC path for theRNSScreen viewDidAppear:swizzle. The SwiftSentrySDK.internal.swizzleAPI introduced in #6380 referencesSentryInternalSwizzleApi.Mode.oncePerClass, an@_spi(Private)enum case whose metadata symbol is not exported from sentry-cocoa's prebuilt static xcframework — compile succeeds via.private.swiftinterface, but link fails on arm64.The ObjC
SentrySwizzleclass +SentrySwizzleModeenum export normally (_OBJC_CLASS_$_SentrySwizzleverified in the arm64 slice), so this call site links cleanly for both the xcframework default and the source-builtSENTRY_USE_XCFRAMEWORK=0fallback. The rest of theSentrySDK.internalmigration in #6380 keeps using the Swift bridge.💡 Motivation and Context
Fixes #6465.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps