ref(resolvers): remove the TraceItemDataResolver abstraction - #8455
Open
MeredithAnya wants to merge 1 commit into
Open
ref(resolvers): remove the TraceItemDataResolver abstraction#8455MeredithAnya wants to merge 1 commit into
MeredithAnya wants to merge 1 commit into
Conversation
No endpoint dispatches through a resolver anymore, so delete TraceItemDataResolver, RPCEndpoint.get_resolver, and the resolvers package -- including the directory-scan auto-import that populated the registry as an import side effect. The modules under resolvers/ that were never resolvers move to homes that describe them, following eefb131: resolvers/common/* -> snuba/web/rpc/common/ R_eap_items/heatmap_builder -> snuba/web/rpc/v1/ R_eap_items/co_occurring_attrs -> snuba/web/rpc/v1/ Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
MeredithAnya
added this pull request to stack #8456
September 9, 2026 23:52
pbhandari
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
ref(resolvers): remove unused resolver declarationsref(resolvers): inline the trace item stats resolverref(resolvers): inline the time series resolverref(resolvers): inline the trace item table resolverref(resolvers): remove the TraceItemDataResolver abstractionWhat
No endpoint dispatches through a resolver anymore, so this deletes:
TraceItemDataResolverandRPCEndpoint.get_resolverinsnuba/web/rpc/__init__.pysnuba/web/rpc/v1/resolvers/package, including the_TO_IMPORTdirectory scan that populated the registry as an import side effectRe-homing the non-resolvers
resolvers/also held modules that were never resolvers and are imported by already-converted endpoints (endpoint_trace_item_attribute_names.py,trace_item_attribute_values.py,endpoint_get_traces.py), so they move somewhere that describes them — followingeefb13118:resolvers/common/{aggregation,trace_item_table,cross_item_queries,formula_reliability}.pysnuba/web/rpc/common/resolvers/R_eap_items/heatmap_builder.pysnuba/web/rpc/v1/resolvers/R_eap_items/co_occurring_attrs/snuba/web/rpc/v1/tests/web/rpc/v1/resolvers/.../co_occurring_attrs/tests/web/rpc/v1/co_occurring_attrs/All
git mv, so they should show as renames.Verification
pytest tests/web/rpc/→ 826 passed, 2 skipped, 2 xfailedmypy snuba/→ clean across 816 filesgrep -rn 'resolver' snuba/web/rpc/returns only the unrelatedsnuba/query/allocation_policies/resolver.pyimportWorth a second look: deleting the
_TO_IMPORTscan removes an import side effect. The passing suite dispatches these endpoints by name over HTTP, which covers registration, but I couldn't run a standalone import smoke check — a barepython -c 'from snuba.web.rpc import RPCEndpoint'fails withAttributeError: METRICS_COUNTERSonmastertoo, so that's a pre-existing settings-profile thing rather than something introduced here.🤖 Generated with Claude Code