ref(pull): clean up pull consumer wiring and get pull-arroyo improvments - #8465
Open
tryangul wants to merge 7 commits into
Open
ref(pull): clean up pull consumer wiring and get pull-arroyo improvments#8465tryangul wants to merge 7 commits into
tryangul wants to merge 7 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4ef6dd3. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Clean up pull consumer wiring: shared resources, factory extraction, module split, and upstream arroyo alignment.
How
Wiring
SharedResources— Kafka producers (DLQ, commit log, COGS) and CH writer created once,Arc-shared across rebalance iterationsmake_kafka_source,make_dlq_handler,make_ch_writer, etc. replace inline constructionpull_consumer.rs→pull_consumer/withentrypoint.rs(bootstrap/runtime),factories.rs(component construction),pipelines.rs(pipeline assembly)Rebalance / rebuild improvements
Pipeline::stream(self, ...)— pipelines consume themselves, dropping the'alifetimePipelineRunner— replaces the hand-rolled rebalance loopUpstream API changes
KafkaProducer::new()→Result— upstream arroyo#563 changed the return type; added.expect()at all call sitesWhy
Notes
KafkaProducer::new.expect()changes inconsumer.rs,factory_v2.rs,accepted_outcomes_consumer.rsare required by the upstream API change, not specific to pullLinks