Conversation
Add condition at adding password to post body Update get_body_3 to have application credential body if auth type is set to v3applicationcredentail
Add three variables: app_cred_id, app_cred_secret, and openstack_auth_type Define validate_auth_type method Move password, username required check into validate_auth_type method since application credential doesnt require username and password Update validate_api_version method since application credential doesnt require other variables like: user_domain or project_name
app_cred_id_required and app_cred_secret_required
Add app_cred_id and app_cred_secret Add keystone_request_body_app_cred Add context with good application credentials Add context with wrong application credentials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch make the plugin support application credential in openstack.