Enable "Do Not Disturb" when active (#15) - #51
Open
devmattrick wants to merge 4 commits into
Open
devmattrick wants to merge 4 commits into
devmattrick wants to merge 4 commits into
Conversation
Owner
|
So sorry, totally missed this! I will have a look asap! |
Owner
|
I think it might need adaptions now that #54 landed (sorry). |
Author
|
No worries! I'll work on it when I get a chance. I think I may also need to make it handle computer restarts because it's possible for do not disturb to get turned on and remain on after the computer restarts. |
- Reset DND mode on extension destroy - Reactively toggle DND mode based on preference state
Author
|
@gicmo this should be ready for review! I believe the failing CI build may be unrelated to this PR but let me know if I inadvertently broke something 🙂 Feel free to request changes as you see necessary! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the "Do Not Disturb" toggle functionality that was mentioned in #15. This is also my first time working on writing GNOME extensions so please let me know if this could be improved in any way.
A small bug that I'm not entirely sure how to fix is there seems to be an issue where the "GameMode is inactive" notification gets sent before "Do Not Disturb" is fully disabled, which leads to the notification not popping up (it still is in the notification area, though). I'd be happy to fix this if anyone has any ideas on how to wait for the setting change to take effect.
Thank you for the awesome extension!