Clarify Autofix deviation approval metadata - #1193
Closed
mbaluda wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation now matches the deviation format’s enforced requirements.
Review tier: Balanced
Findings: None
What changed in this PR
Clarifies valid deviation metadata for Agentic Autofix.
Changes:
- Requires initial fixes to omit both approval metadata fields.
- Allows human reviewers to add both fields during approval.
| File | Description |
|---|---|
docs/autofix-instructions.md |
Documents valid handling of deviation approval metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarify that Agentic Autofix must omit both
raised-byandapproved-byfrom an initial false-positive deviation record. The deviation format requires these fields to be specified together, so a human reviewer may add both when approving the deviation.This prevents Autofix from generating an invalid record while preserving human approval of deviations.
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note is required for changes to release artifact structure, query performance, or query results. This documentation-only change affects none of those.
Author: Is a change note required?
Reviewer: Confirm that format of shared queries is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
Not applicable; this pull request does not add or modify queries.