Unified: Add a debug query to view the AST as a graph. - #22474
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The edge relation reverses parent-child direction and may reference filtered-out nodes.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
unified/ql/lib/codeql/unified/internal/dev/debugAst.ql — The edge relation is reversed and can reference nodes omitted by nodes: pred is bound to a… |
What changed in this PR
Adds a developer query for visualizing Unified AST nodes as a graph.
Changes:
- Filters AST nodes by source location.
- Adds customizable node and edge labels.
| File | Description |
|---|---|
unified/ql/lib/codeql/unified/internal/dev/debugAst.ql |
Implements the AST debug graph query. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+45
to
+49
| relevant(succ) and | ||
| exists(int i | | ||
| pred = getChild(succ, i) and | ||
| val = i + " " + concat(string t | t = etag(pred, succ) | t, ", ") | ||
| ) |
asgerf
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find this quite useful, and easier to inspect than the regular AST viewer.