Unified: Add some more AST classes. - #22475
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new public logical-expression classifications lack direct QL library tests.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
unified/ql/lib/codeql/unified/internal/AstExtra.qll — Add a unified library test that queries LogicalOrExpr, NullCoalescingExpr, and LogicalNotExpr… |
What changed in this PR
Adds unified AST abstractions for binary and logical expressions.
Changes:
- Adds shared binary-expression operand traversal.
- Adds logical OR, null-coalescing, and logical NOT classifications.
| File | Description |
|---|---|
FacadeAst.qll |
Adds the BinaryExpr facade and operand accessor. |
AstExtra.qll |
Adds logical-expression classes based on operator shape. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+13
to
+15
| /** A short-circuiting logical OR expression. */ | ||
| class LogicalOrExpr extends BinaryExpr { | ||
| LogicalOrExpr() { this.getOperator().getValue() = "||" } |
asgerf
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.