Unified: Move extension workaround into static name binding library - #22481
Merged
hvitved merged 1 commit intoSep 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Qualified extension targets such as Outer.Inner remain unresolvable because they are represented as one identifier.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
unified/ql/lib/codeql/unified/internal/LocalNameBinding.qll — This only turns unqualified extension targets into usable accesses. The Swift mapper stores the… |
What changed in this PR
Moves Swift extension-target handling into local/static name binding.
Changes:
- Treats extension names as accesses rather than declarations.
- Removes downstream extension-specific exclusions.
- Adds an unqualified extension binding test.
| File | Description |
|---|---|
AnalysisQuality.qll |
Includes extension targets in resolution statistics. |
LocalNameBinding.qll |
Reclassifies extension names as accesses. |
StaticNameBinding.qll |
Removes the folder-level workaround. |
test.swift |
Tests unqualified extension resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hvitved
force-pushed
the
unified/static-namebinding-extensions
branch
from
September 1, 2026 12:11
4e38438 to
3ca261a
Compare
hvitved
marked this pull request as ready for review
September 1, 2026 12:12
asgerf
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.