Add actions.lock extraction - #22487
Merged
Merged
Conversation
hvitved
force-pushed
the
hvitved-actions-lock-extraction
branch
3 times, most recently
from
September 2, 2026 08:32
27db0c5 to
f929753
Compare
Teach the JavaScript extractor to classify .lock files as YAML while limiting default autobuild extraction to explicitly included paths. Expose Actions lockfiles through the ActionsLock QL class and cover extraction with QL and database-creation integration tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4994bb27-c5ca-47e9-b082-cfc1ca244e86
hvitved
force-pushed
the
hvitved-actions-lock-extraction
branch
from
September 2, 2026 08:44
f929753 to
2377214
Compare
hvitved
marked this pull request as ready for review
September 2, 2026 11:56
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The baseline path configuration still filters out actions.lock during normal Actions extraction.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
actions/extractor/tools/autobuild.sh — configure-baseline still returns baseline-config.json without **/actions.lock. Those baseline… |
What changed in this PR
Adds actions.lock extraction and a QL abstraction for Actions databases.
Changes:
- Treats
.lockfiles as YAML while excluding them from default JavaScript extraction. - Includes
actions.lockin Actions extraction filters. - Adds
ActionsLock, tests, fixtures, and release notes.
| File | Description |
|---|---|
javascript/extractor/src/com/semmle/js/extractor/FileExtractor.java |
Classifies .lock as YAML. |
javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java |
Excludes lockfiles by default. |
actions/ql/lib/codeql/actions/Lock.qll |
Defines ActionsLock. |
actions/ql/lib/actions.qll |
Exports lockfile support. |
actions/ql/lib/change-notes/2026-09-01-actions-lock-yaml.md |
Documents the feature. |
actions/extractor/tools/autobuild.sh |
Includes Actions lockfiles on Unix. |
actions/extractor/tools/autobuild-impl.ps1 |
Includes Actions lockfiles on Windows. |
actions/ql/test/library-tests/actions-lock/test.ql |
Queries extracted lockfiles. |
actions/ql/test/library-tests/actions-lock/test.expected |
Records expected query output. |
actions/ql/test/library-tests/actions-lock/options |
Selects the test lockfile. |
actions/ql/test/library-tests/actions-lock/actions.lock |
Supplies the library-test fixture. |
actions/ql/test/library-tests/actions-lock/.github/workflows/test.yml |
Supplies workflow context. |
actions/ql/integration-tests/actions-lock/test.py |
Tests normal database extraction. |
actions/ql/integration-tests/actions-lock/src/actions.lock |
Supplies the integration fixture. |
actions/ql/integration-tests/actions-lock/src/.github/workflows/test.yml |
Supplies integration workflow context. |
actions/ql/integration-tests/actions-lock/query/qlpack.yml |
Configures the integration query pack. |
actions/ql/integration-tests/actions-lock/query/actions.ql |
Checks lockfile availability. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
asgerf
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions databases currently skip
actions.lock, preventing queries from inspecting pinned action versions recorded in lockfiles.This change teaches the JavaScript extractor used by the Actions extractor to classify
.lockfiles as YAML. The Actions path filters limit extraction toactions.lock, while the focusedActionsLockQL class exposes those documents to queries. A normal Actions QL extraction test verifies the lockfile is available.