chore: update @girs dependencies to latest - #144
Merged
Conversation
JumpLink
marked this pull request as ready for review
August 29, 2026 06:34
JumpLink
requested review from
JumpLink,
Totto16,
schnz and
swsnr
as code owners
August 29, 2026 06:34
This was referenced Aug 29, 2026
`@girs/gnomebg-4.0` 4.3.0 adds the promisified overloads of
`BGSlideShow.load_async`; 4.1.0 declared a single callback signature. The
shell subclasses that class in `ui/background.js` and overrides the method
with a callback-only form, which no longer satisfies the base type:
error TS2416: Property 'load_async' in type 'Animation' is not
assignable to the same property in base type 'BGSlideShow'.
So declare the one-argument form on the override as well, marked
`@hidden` and `@deprecated`. The shell always hands its own callback down
to the base method, so nothing is promisified here. Awaiting the result
resolves at once, with the slide show still unloaded.
JumpLink
force-pushed
the
chore/update-girs
branch
from
August 29, 2026 06:59
e92a2d3 to
1e40948
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated update of the
@girs/*type dependencies to their latest npmlatestdist-tag.Dependencies use caret ranges (
^x.y.z) on the release-only@girsversion scheme (ts-for-gir >= 4.1): a caret dedupes across stable releases and excludes prereleases. This job advances the caret floor to the latest release. Seescripts/update-girs.mjsfor the full explanation.Triggered by:
workflow_dispatch.