Fix harmmean Inf vecdim validation - #510
Open
sahilphad07-sudo wants to merge 1 commit into
Open
sahilphad07-sudo wants to merge 1 commit into
sahilphad07-sudo wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
harmmeanacceptedInfvalues in thevecdimargument and silently ignored them. MATLAB rejects non-finite dimension values with an error.This change updates
vecdimvalidation to reject non-finite values, matching MATLAB behavior.Before
After
The same validation now applies to all occurrences of
Infinvecdim.MATLAB Behavior
Regression Tests Added
InfdimensionInfafter a valid dimension:[1 Inf]Infbefore a valid dimension:[Inf 1]Infdimensions:[Inf Inf]Test Results
All existing and new
harmmeanBISTs pass: