fix: RenameIndex and DropIndex failing on CURRENT_SCHEMA() - #351
Open
keif888 wants to merge 3 commits into
Open
Conversation
…e for ALTER and DROP statements. CurrentSchema function now retrieves the value from current_schema() and returns instead.
…hich returns a NULL from current_schema()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
This pull request fixes issue #350, by retrieving the value of current_schema() when needed, and wrapping the result in a clause.Column within RenameIndex and DropIndex
PR #349 is another attempt to address this issue, in a slightly different way.
Which of these solutions is better I leave up to the Maintainers to decide.
User Case Description
As a developer I want to be able to drop indexes within a Postgres database using code as per the TestMigrateIndexes gorm testing function:
As a developer I want to be able to rename indexes within a Postgres database using code as per the TestMigrateIndexes gorm testing function:
Testing
This PR has been tested via the gorm test_all.sh script, with the go.mod file modified to use this version of the postgres driver, instead of the published version.
mod.go change:
Test results: